eo-yaml
eo-yaml copied to clipboard
decorators-squad
Scalar issue regarding quoted colons
Due to how the regex pattern and indexOf(":") are set up in ReadPlainScalar and ReadYamlMapping, keys and values like this isn't handled correctly. For example:
"interactionvisualizer:crafting_table": "Crafting Table"
Modes: "Toggle Modes: itemstand, itemdrop, hologram"
For values, it would match the last occurring ":". For keys, it will always match the first ":", disregarding whether it is quoted or not.
(I've forked to the repo to sort of fix it myself with a few changes)
@LOOHP thank you for reporting this. I'll assign someone to take care of it soon.
@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.
Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.
@LOOHP It would be useful to submit a PR with a failing unit tests which illustrates this bug exactly. Then we have a good starting point for fixing : D
I've submitted one test each for ReadPlainScalar and ReadYamlMapping which fails due to this bug.
this has been mostly fixed with release 7.0.3. Only small details remaining, to be released with 7.0.4
@LOOHP This is mostly fixed in 7.0.3, only small details remain to be release with 7.0.4, very soon.