Harsh Singh

Results 36 comments of Harsh Singh

@mtreacy002 Added new tests, I am not much confident on the tests, So I request the review team for a good check and let me know whether this is right...

> > Also, I suggest using selenium testing method (Used in VMS) for better testing, It will be useful for frontend as well as backend > > I don't know...

Hey @mtreacy002 so sorry I wasn't able to reply to you , I am currently preoccupied with my personal urgent works . I will check all the message and do...

@mtreacy002 Thank you for being very patient and helpful. Easy changes are done for now! Please have a look. Yeah, I copied the code skeleton from MS backend resources/mentorship_relation.py forgot...

> @decon-harsh, I think we might need to create a different request body for the BIT app/api/model/mentorship_relation. This is because the request is not actually done between mentee and mentor...

@mtreacy002 Yeah, my mistake I fixed Mentor to be org.rep_id. The 1st approach would be fine , and I will be happy to solve this cross project issue at MS...

Yeah and till then I will note down what and how I will implement these. Will keep you updated @mtreacy002

@mtreacy002 Any updates on this. Creating DAO on your version of MS Backend got approved?

@mtreacy002 Can we do this? 1. Create A new table in BIT where we store (id,org_id,program_id,mentor_id,mentor_state,mentee_id,mentee_state) mentee and mentor field are nullable . 2. Think of this like temporary storage...

One more thing @mtreacy002 , While I was going through the gists you provided , i came across this problem . There is a problem of state in that approach...