[global-hooks][deckhouse_registry] confusing values path

[apolovov]

Preflight Checklist

• [X] I agree to follow the Code of Conduct that this project adheres to.
• [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Version

v1.26

Expected Behavior

DIscovery global hooks should save their discovered data to global.discovery.

Actual Behavior

The hook is saving discovered data to global.modulesImages, which causes a wrong expectation that I can override it with deckhouse CM.

Steps To Reproduce

No response

Additional Information

No response

Logs

No response

[EvgenySamoylov]

@name212 looks like linked with #330. Could you please look into this?

[name212]

We added openapi spec for global values. Specs were separated on two parts: for values from configmap d8-system/deckhouse and for internal values from hooks.

Therefore, we decide that moving modulesImages to discovery subobject is not necessary.

[apolovov]

The issue wasn't about my ability to override values via cm. The issue was about values scheme clarity and transparency to understand. The scheme gives false hope that I can override the value via CM.

[apolovov]

The decision

• move to discovery:

clusterConfiguration
clusterIsBootstrapped:
deckhouseEdition:
deckhouseVersion:
modulesImages:

• move to modules:

storageClass

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nabokihms]

This is a technical debt. @EvgenySamoylov let's add this to our future plans.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically closed because it has not had activity in the last month and a half. If this issue is still valid, please ping a maintainer and ask them to check this again. Thank you for your contributions.