Ralph Caraveo
Ralph Caraveo
Hello, Thanks for the issue. I haven’t audited the locking code in a long time. I’m aware of the defer keyword but there was a decision to avoid defer due...
Excellent catch! This is definitely an issue. I'll follow-up with a PR unless someone gets to it before me! Here's my plan of action: - Immediately fix the `Each` function...
You know what, after taking a closer look at `Each`, this is not an early return. This is just a `break` statement so all it means is the for loop...
https://github.com/deckarep/golang-set/pull/164 @hemflit - it seems fitting that you can take a gander at my PR. Mainly the test case which I have simplified to have a little less boilerplate.
Hello, Thanks for the recommendation! I'm certainly not opposed to changes that would be considered general enough that others would find useful and if you have an API in mind...
Sounds good I’ll be looking at this next week due to a new project deadline so please forgive the upcoming delay! On Wed, Jul 10, 2024 at 4:01 PM Michael...
@ScreamingHawk - circling back on this seems like this would be a fairly large breaking change. I understand what your concern is but I do feel like this would possibly...
Thanks for the heads up on this. Looks like it breaks the build which I imagine is because the Zig CI workflow is likely still pinned to the 0.14.0 release....
Absolutely! And I’ll leave it open for a while since we will need this eventually. Then I’ll merge it. I appreciate any and all contributions and thanks again! If you...
Hello @amikai - this looks great. * Since Go did not have language supported, built-in iterators all of my solutions were less than ideal. * I agree it would be...