decidim
Fix inappropriate roles menu and menuitem in footer links
:tophat: What? Why?
This PR removes inappropriate roles menu and menuitem in footer. It is issued from the audit of Angers city (page 33), and corresponds to criterias 2.5.3 and 4.1.2 from WCAG.
Testing
As a user, go to the dev tools and check that roles menu and menuitem are not present in footer links.
:camera: Screenshots
:hearts: Thank you!
@Stef-Rousset Can you fix this pipeline ?
hello @alecslupu , I will take a look this week !
Hello @alecslupu , I made an update to fix the failing accessibility tests on account page. Please let me know if it's ok !
@Stef-Rousset Any updates on this matter ? ( the same described in #14951)
Hello @alecslupu , I have added the js again for account page, everything seems ok now !
@Stef-Rousset I have checked again this, and the previous error i have mentioned (WGAC error ) can be fixed if i add a timeout on axe script.
However, if i apply this fix, the user menu will not be collapsed.
@Stef-Rousset I have checked again this, and the previous error i have mentioned (WGAC error ) can be fixed if i add a timeout on axe script.
However, if i apply this fix, the user menu will not be collapsed.
Hello @alecslupu , I removed the js added, so that you can apply your fix ! I have also fixed 2 failing tests. However, some tests seems to be unstable, as you can see on the img, the failing tests before I triggered the CI are not the same as the ones that fails now...
Having 0.31 releases, we do not longer release 0.29.x series as per policy. Removing release: v0.29
Hey @Stef-Rousset is this still being worked on? I've noticed there are conflicts and its currently 190 commits behind the develop branch.
Do you have time to take a look into this?
