veramo icon indicating copy to clipboard operation
veramo copied to clipboard

ION DID Provider and Resolver Implementation

Open rado0x54 opened this issue 3 years ago • 7 comments

This branch provides support for did:ion in veramo.

Do not merge prior to the following issues being resolved:

  • JWK Key handling in Veramo
  • 50 char Key ID restriction in ION / key.kid in Veramo
  • Transmute did-key dependencies for tooling (transitive in ion-tools)
  • General dependency bloat: yarn.lock ++ 4000 lines.
  • Source for verificationMethodTypes et al.
  • ion-tools currently only supports create operation

Relates to #336

rado0x54 avatar Mar 31 '21 14:03 rado0x54

Codecov Report

Merging #440 (17e28cc) into next (88264db) will decrease coverage by 2.91%. The diff coverage is 44.88%.

:exclamation: Current head 17e28cc differs from pull request most recent head 17178fe. Consider uploading reports for the commit 17178fe to get more accurate results

@@            Coverage Diff             @@
##             next     #440      +/-   ##
==========================================
- Coverage   67.58%   64.67%   -2.92%     
==========================================
  Files          62       74      +12     
  Lines        1530     1704     +174     
  Branches      247      277      +30     
==========================================
+ Hits         1034     1102      +68     
- Misses        400      496      +96     
- Partials       96      106      +10     

codecov[bot] avatar Mar 31 '21 14:03 codecov[bot]

Relates to #336

rado0x54 avatar Mar 31 '21 15:03 rado0x54

The full ion-tools support is effectively blocked by https://github.com/decentralized-identity/ion-tools/issues/3 (Lack of update functionality)

rado0x54 avatar May 18 '21 13:05 rado0x54

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 28 '21 16:08 stale[bot]

@rado0x54 as an FYI, this support was added in (at least according the csuwildcat) in that GitHub issue you mention from decentralized identity.

mikhael28 avatar Apr 06 '22 14:04 mikhael28

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 05:07 stale[bot]

Just wanted to let you know we are working on creating a full implementation that supports recovery and updates, as well as generating keys on the fly and importing keys. It started out as a fork of this PR, as we need it for certain projects. But right now we need to have a fully working implementation soon. After the work in the URL is complete, we will create a PR to merge it into Veramo directly.

Next to the remaining work, there is a big issue currently with getting everything to work in React-Native. We had to fork several ION packages to get it to work. After the full implementation we will solve these ports in a nicer way as well.

If you are curious https://github.com/Sphereon-Opensource/ssi-sdk/tree/feature/WAL-246/packages/ion-did-provider

nklomp avatar Aug 05 '22 20:08 nklomp

Probably it makes sense to close this PR, as it is superseded by https://github.com/uport-project/veramo/pull/987

nklomp avatar Aug 24 '22 17:08 nklomp

Correct, thanks for flagging it!

mirceanis avatar Aug 24 '22 17:08 mirceanis