universal-registrar
universal-registrar copied to clipboard
chore: Add trustbloc driver
@peacekeeper can you review this PR
Hey @fqutishat, I tried it and it seems to work, but I would be curious about your thoughts on the following:
- Regarding the "jobId" parameter, my idea was that this would only ever be used if register/update/deactivate requires multiple steps. For example, the client calls the /register endpoint, and then the response includes a "jobId", which can then be used by the client in subsequent calls. But in your example, a "jobId" is already present in the original call. Is there a reason for that? Are you using this parameter for anything?
- My original thought for the Universal Registrar architecture was that key pairs would be generated inside the driver, and then both the private and public key would be returned to the client. I think there is an open issue about that somewhere, but I can't find it now. In your driver, where are the private keys created and stored?
- I'm also curious how you are using the "didDocument" parameter that a client passes into the driver.
Maybe we can discuss this in the DIF ID WG Slack channel, or on a call..?
@peacekeeper I will remove "jobId" from register request