element icon indicating copy to clipboard operation
element copied to clipboard

Not usable on Node.js 12

Open filips123 opened this issue 5 years ago • 9 comments

Truffle and its sub-packages (truffle-contract) are unusable on Node.js 12 (trufflesuite/truffle#2070). Because of that, this package is also unusable on Node.js 12.

filips123 avatar Jun 02 '19 13:06 filips123

@filips123 thanks for opening this! As you noted, we'll need to keep an eye on truffle and upgrade once they add support.

OR13 avatar Jun 03 '19 14:06 OR13

Bumping this issue to a bug, we really would love to use node 12... especially because it is a requirement for https://github.com/panva/jose

OR13 avatar Jul 26 '19 22:07 OR13

@OR13 This will probably be fixed in next version of Web3.

filips123 avatar Jul 27 '19 08:07 filips123

This has been fixed on truffle/web3 https://github.com/ethereum/web3.js/issues/2913

mkhraisha avatar Nov 14 '19 16:11 mkhraisha

Looks like this is still blocked because of another dependency of @truffle/hdwallet-provider

See: https://github.com/trufflesuite/truffle/issues/2070#issuecomment-554140180

https://github.com/ethereumjs/ethereumjs-wallet/pull/91

gjgd avatar Nov 14 '19 23:11 gjgd

sadness... thanks for pinging those issues.

OR13 avatar Nov 15 '19 00:11 OR13

Most features seem to be working in node 12 but a couple of tests are failing, mmmh. Looks like it's related to the truffle wallet

https://travis-ci.org/decentralized-identity/element/builds/612247263

gjgd avatar Nov 15 '19 08:11 gjgd

I'm still having trouble with this issue:

error @transmute/[email protected]: The engine "node" is incompatible with this module. Expected version ">=10.0 <12.0". Got "12.14.1"

coder5876 avatar Jan 23 '20 22:01 coder5876

Hi @christianlundkvist , thanks for being vigilant about this issue!

As far as I can see, with the latest version of truffle (which was the last blocking dependency), Element now works with Node 12.

I've opened a PR to remove the <12 constraints in package.json. We'll let you know in this thread as soon as we ship the next version that contains this change.

gjgd avatar Jan 24 '20 05:01 gjgd