dwn-sdk-js icon indicating copy to clipboard operation
dwn-sdk-js copied to clipboard

Increase code coverage (even if just by a little bit)

Open thehenrytsai opened this issue 3 years ago • 7 comments

Background:

The code coverage goal is 100% for this repo, so any PR adding any test to increase the overall code coverage would be super useful!

Task Details:

To know what code hasn't been covered:

  1. Run npm run test:node
  2. Ignore the code coverage summary at the end of the run, there is a better way:
  3. Use MacOS Finder or Windows Explorer to open the coverage/index.html page, it will show you precisely what line of code is not covered

Files that can be ignored as they will likely be undergoing drastic changes:

  • permissions-request.ts

Picking Up This Issue:

  • If you'd like to work on this, please comment "picking this up" below, and I'll assign the issue to you

Questions:

Resources:

  • Creating a Pull Request: If you're new to GitHub and unsure how to create a pull request, follow this step-by-step guide.

Remember, communication is key! If you have any questions or face any challenges, we're here to help so please don't hesitate to reach out.

Good Luck! 🍁

thehenrytsai avatar Nov 04 '22 20:11 thehenrytsai

PR to test utils/object/removeUndefinedProperties: 154

alexlemons avatar Nov 14 '22 17:11 alexlemons

picking this up

tux7P avatar Sep 27 '23 07:09 tux7P

@tux7P Yay! I'll assign it to you now.

I'd also like to note that Hacktoberfest officially kicks off on October 1st. Contributions made before the event may not be eligible for the challenge. However, feel free to start working on it, but I'd recommend holding off on submitting your PR until the event begins.

to be eligible for Hacktoberfest's official prizes make sure you're registered, registration is now open. Reach out if you need any help 🥳

Good Luck 🍁

EbonyLouis avatar Sep 28 '23 15:09 EbonyLouis

More than one person can work on this issue, feel free to comment "picking this up" if it interest you! 🍁

EbonyLouis avatar Sep 28 '23 15:09 EbonyLouis

@EbonyLouis, picking this up!

shobitb avatar Oct 10 '23 17:10 shobitb

Heyy @tux7P how are things going with this issue? Is this something you still want to work on?

EbonyLouis avatar Oct 16 '23 17:10 EbonyLouis

@EbonyLouis picking this up !

Tushar98644 avatar Oct 21 '23 08:10 Tushar98644