unity-renderer
unity-renderer copied to clipboard
fix: Culling controller refactor
fixes PR https://github.com/decentraland/unity-renderer/pull/3208
The new Culling tracker loads the renderers information in different frames avoiding spikes, this caused an issue when an already detected renderer was removed during the process, this new PR fixes that.
Old merged PR: Culling now optimizes a set of elements in order to have faster calculation times and increased performance as a consequence.
How to test the changes? QA
The culling system has received an overhaul, we have to make sure the culling is still working as expected.
- Shadows should work the same as in dev.
- Objects should be drawn under the same rules as in dev
- Animations should be displayed like in dev.
After the CI passes:
- This branch can be previewed at https://play.decentraland.zone/?renderer-branch=refactor/Culling-controller-refactor
- Code coverage report: https://renderer-artifacts.decentraland.org/branch-coverage/refactor/Culling-controller-refactor
- Benchmark report: https://renderer-artifacts.decentraland.org/branch-benchmark/refactor/Culling-controller-refactor/index.html
This is the only change compared to the last approved and merged PR