unity-renderer icon indicating copy to clipboard operation
unity-renderer copied to clipboard

fix: Culling controller refactor

Open PalauiDCL opened this issue 2 years ago • 2 comments

fixes PR https://github.com/decentraland/unity-renderer/pull/3208

The new Culling tracker loads the renderers information in different frames avoiding spikes, this caused an issue when an already detected renderer was removed during the process, this new PR fixes that.

Old merged PR: Culling now optimizes a set of elements in order to have faster calculation times and increased performance as a consequence.

How to test the changes? QA

The culling system has received an overhaul, we have to make sure the culling is still working as expected.

  • Shadows should work the same as in dev.
  • Objects should be drawn under the same rules as in dev
  • Animations should be displayed like in dev.

PalauiDCL avatar Oct 26 '22 06:10 PalauiDCL

After the CI passes:

github-actions[bot] avatar Oct 26 '22 06:10 github-actions[bot]

image This is the only change compared to the last approved and merged PR

PalauiDCL avatar Oct 26 '22 06:10 PalauiDCL