unity-renderer icon indicating copy to clipboard operation
unity-renderer copied to clipboard

Refactor/stickers controller QA

Open PalauiDCL opened this issue 2 years ago • 1 comments

QA

This PR only exists in order to create a testing ground for QA The stickers refactor changed how stickers are instantiated, but there should be no visible changes for them

Original PR: https://github.com/decentraland/unity-renderer/pull/3298

PalauiDCL avatar Oct 26 '22 06:10 PalauiDCL

After the CI passes:

github-actions[bot] avatar Oct 26 '22 06:10 github-actions[bot]

The issue with the emote particles spawning below the ground no longer occurs. In the latest branch, a new issue was introduced causing the emote particles to spawn too high. The issue occurs for all of the emotes with particles. The videos from both the branch (https://user-images.githubusercontent.com/110464313/200006235-8f45d26e-b86c-4543-bfa0-4aeb69a6d3e9.mp4) and the production configurations (https://user-images.githubusercontent.com/110464313/200006297-90d9662e-3627-425e-ac9c-16130c61e678.mp4) were added for comparison.

@kwspgoliasz The issue should be corrected now ^^

PalauiDCL avatar Nov 07 '22 01:11 PalauiDCL

@PalauiDCL could you do the changes requested by QA? Let's close this soon :)

xavi-dcl avatar Nov 14 '22 16:11 xavi-dcl

@PalauiDCL should this PR be marked as do not merge. All the changes are the same as here https://github.com/decentraland/unity-renderer/pull/3298 @aixaCode The one unused is the other, I marked it as do not merge.

aixaCode avatar Nov 14 '22 17:11 aixaCode