unity-renderer icon indicating copy to clipboard operation
unity-renderer copied to clipboard

feat: [SUB-BRANCH] Implement channel list of players and counter

Open sandrade-dcl opened this issue 2 years ago • 2 comments

What does this PR change?

Fix #2735

In order to know who are you talking with within channels, players need a way to know the number of players connected to the same channel.

The players will be listed in a new section, accessible by a button in the channel conversation view. The channels will display the number of connected players next to their name in the conversations list view.

image

Figma design: https://www.figma.com/file/SxxomcIZI1zyytMZmFJAvS/Social-Improvements?node-id=3303%3A39380 Data Flow: https://hackmd.io/sMgwddkUR_SDZvWqLlFfeg?view#Ability-to-get-the-list-of-users-joined-to-a-channel

How to test the changes?

  1. Go to: https://play.decentraland.org/?renderer-branch=feat/implement-channel-list-of-players-and-counter&kernel-branch=feat/add-friends-lazy-load
  2. Join any channel.
  3. Expand the new members section.
  4. Notice a list of users are loaded.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

sandrade-dcl avatar Aug 30 '22 11:08 sandrade-dcl

After the CI passes:

github-actions[bot] avatar Aug 30 '22 11:08 github-actions[bot]

The window fades out if i leave the mouse over the member list after a couple of seconds. The window should remain visible because the member list should be part of the focus area.

lorux0 avatar Sep 07 '22 18:09 lorux0