unity-renderer icon indicating copy to clipboard operation
unity-renderer copied to clipboard

"Texture" Wearable requested multiple times

Open pbosio opened this issue 4 years ago • 1 comments

Related to #837 In crowded areas when avatars go far away and then come close again we can notice that wearables that are textures (not gltf) are being requested again to the content server. Since user go outside comms area, the avatar was cleaned up and the ref count for that wearable texture decreased to 0

pbosio avatar Sep 08 '21 22:09 pbosio

@menduz I understand that the content server requests load aren't an issue right?

This was requested by @pentreathm.

Please confirm that this really should be done.

BrianAmadori avatar Sep 10 '21 13:09 BrianAmadori

In order to validate this:

  • Open two explorer windows
  • Move far away with one avatar with many wearables, until the avatar is unloaded, and then, move back again
  • Check that the network tab in chrome dev tools does not trigger a network request again

eordano avatar Dec 21 '22 12:12 eordano

This is a very old issue but I would like to verify it

m3taphysics avatar May 31 '23 07:05 m3taphysics

I have been testing what Esteban said: using 2 browsers with different users (one of them with wallet and another one as guest), when the other user go far away and go back to the view of the first one, in the network tab we are always receiving a serie of requests related to /content/contents/... belonged (I don't know why) to some base wearables that has not to be with the equipped wearables of the avatar in the scene. However the content related to the specific users that go far away and go back seems to be cached correctly.

image.png

sandrade-dcl avatar Jul 12 '23 10:07 sandrade-dcl

I think the problem is that we're not implementing any kind of cache in the LazyTextureObserver class (or even AssetPromise_Texture), so each time we load a texture from an url (like an impostor texture), we are requesting the url again.

(Maybe another solution would be create a cache system ONLY for impostors textures from the AvatarShape.)

NOTE: Solution pending to discuss with the tech leads.

sandrade-dcl avatar Jul 13 '23 09:07 sandrade-dcl