builder icon indicating copy to clipboard operation
builder copied to clipboard

feat: Use controller registrar from transactions

Open fzavalia opened this issue 1 year ago • 2 comments

Closes #2562

I created getContractAddressForAppChainId to obtain the corresponding contract for the CHAIN_ID defined in the dev|prod|stg.json files. It would work for Ethereum only contracts which is enough for this case.

Currently failing because https://github.com/decentraland/decentraland-transactions/pull/67 needs to be resolved first

fzavalia avatar Apr 25 '23 21:04 fzavalia

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 7:28pm

vercel[bot] avatar Apr 25 '23 21:04 vercel[bot]

Pull Request Test Coverage Report for Build 4802388124

  • 4 of 9 (44.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 16.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/ens/utils.ts 0 1 0.0%
src/modules/ens/sagas.ts 3 7 42.86%
<!-- Total: 4 9
Totals Coverage Status
Change from base Build 4755988459: -0.004%
Covered Lines: 3064
Relevant Lines: 14441

💛 - Coveralls

coveralls avatar Apr 25 '23 21:04 coveralls