builder icon indicating copy to clipboard operation
builder copied to clipboard

feat: add play-mode to Emotes metadata

Open juanmahidalgo opened this issue 2 years ago • 2 comments

juanmahidalgo avatar Sep 21 '22 13:09 juanmahidalgo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
builder ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 2:42PM (UTC)

vercel[bot] avatar Sep 21 '22 13:09 vercel[bot]

Pull Request Test Coverage Report for Build 3128647483

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 13.006%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/item/utils.ts 0 2 0.0%
<!-- Total: 0 2
Totals Coverage Status
Change from base Build 3105904700: -0.002%
Covered Lines: 2215
Relevant Lines: 13866

💛 - Coveralls

coveralls avatar Sep 21 '22 13:09 coveralls

Approved assuming this urn format is correct ${version}:${type}:${name}:${description}:${category}:${bodyShapeTypes}:${playMode}

fzavalia avatar Sep 26 '22 13:09 fzavalia

Approved assuming this urn format is correct ${version}:${type}:${name}:${description}:${category}:${bodyShapeTypes}:${playMode}

I believe it doesn't translate into an urn directly. It's parsed later on by the collections graph to create the entities. The urn does not support playMode at the end, do you believe that's an issue @fzavalia ?

juanmahidalgo avatar Sep 26 '22 13:09 juanmahidalgo

Approved assuming this urn format is correct ${version}:${type}:${name}:${description}:${category}:${bodyShapeTypes}:${playMode}

I believe it doesn't translate into an urn directly. It's parsed later on by the collections graph to create the entities. The urn does not support playMode at the end, do you believe that's an issue @fzavalia ?

Seems ok 😄

fzavalia avatar Sep 26 '22 13:09 fzavalia

as discussed offline, i'd suggest not incorporating the concept of playMode into the system other than for the UI/UX, and keep the value as loop: boolean to match the ADR74 schema. So we could just store 0 or 1 in this slot in order to tell the subgraph the boolean value.

cazala avatar Sep 26 '22 14:09 cazala