builder
builder copied to clipboard
feat: add play-mode to Emotes metadata
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
builder | ✅ Ready (Inspect) | Visit Preview | Sep 26, 2022 at 2:42PM (UTC) |
Pull Request Test Coverage Report for Build 3128647483
- 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.002%) to 13.006%
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
---|---|---|---|
src/modules/item/utils.ts | 0 | 2 | 0.0% |
<!-- | Total: | 0 | 2 |
Totals | |
---|---|
Change from base Build 3105904700: | -0.002% |
Covered Lines: | 2215 |
Relevant Lines: | 13866 |
💛 - Coveralls
Approved assuming this urn format is correct ${version}:${type}:${name}:${description}:${category}:${bodyShapeTypes}:${playMode}
Approved assuming this urn format is correct
${version}:${type}:${name}:${description}:${category}:${bodyShapeTypes}:${playMode}
I believe it doesn't translate into an urn directly. It's parsed later on by the collections graph to create the entities. The urn does not support playMode
at the end, do you believe that's an issue @fzavalia ?
Approved assuming this urn format is correct
${version}:${type}:${name}:${description}:${category}:${bodyShapeTypes}:${playMode}
I believe it doesn't translate into an urn directly. It's parsed later on by the collections graph to create the entities. The urn does not support
playMode
at the end, do you believe that's an issue @fzavalia ?
Seems ok 😄
as discussed offline, i'd suggest not incorporating the concept of playMode
into the system other than for the UI/UX, and keep the value as loop: boolean
to match the ADR74 schema. So we could just store 0
or 1
in this slot in order to tell the subgraph the boolean value.