builder icon indicating copy to clipboard operation
builder copied to clipboard

Fix selector with parameters not memoizing correctly

Open juanmahidalgo opened this issue 2 years ago • 0 comments

🎉 Description

As we're using reselect 4.0.0, we can't define the selectors with parameters as we did with getStatusForItemIds. That feature was introduced in 4.1.0, so that function is not memoizing correctly, meaning it's computing the output on every single re-render.

  • [X] 🐛 This is a bug report.
  • [ ] 📈 This is a feature request.

📝 Details

Analyse if it's possible to update reselect (I tried it but it throw a lot of errors, looks like they introduced breaking changes) OR create a selector using lodash's memoize function as a work-around (as it was done here)

juanmahidalgo avatar Apr 05 '22 10:04 juanmahidalgo