decap-cms
decap-cms copied to clipboard
1896 fetching other collections from preview
Summary
Allowing users to access data from other collections whilst in the preview pane.
See the comments here: https://github.com/netlify/netlify-cms/issues/1896
This is my first time contributing to this repo, so I'm not 100% across the code base, so feedback is welcome.
I've tested this on a project I am working on at the moment and it worked as expected:
- I was able to pull in all posts to a listing page
- I was able to render the header and footer which are separate collections on every page
Checklist
Please add a x
inside each checkbox:
- [x] I have read the contribution guidelines.
- [x] Code is formatted via running
yarn format
. - [x] Tests are passing via running
yarn test
. - [x] The status checks are successful (continuous integration). Those can be seen below.
Would love to see this feature in Netlify CMS. Anyone from the team interested in taking a look?
This would be a great feature.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@cdennington are you still interested in moving this forward?
@martinjagodic I'd happily be involved in pushing this one out, what do you need from me? Other than fixing conflicts
@cdennington great. Please solve conflicts first and then we will review. Thanks!
@cdennington linter is failing. Please run npm run lint
locally to see the problem.
@martinjagodic, cdennington didn't have the time to finish this, so I took over.
With the docs moving to a different repo, I guess I should just make a seperate pull request there to add the docs for this?
With the docs moving to a different repo, I guess I should just make a seperate pull request there to add the docs for this?
Yes please
Added the pull request for the documentation (written by @cdennington) here: https://github.com/decaporg/decap-website/pull/55.
Not sure why the macos build is failing, it seems to get stuck installing dependencies. No changes have been made to those.
This is great @Boelensman1, MacOS build is a bit cranky sometimes, don't worry about it :)
Left you one little question otherwise this is good to go and can be released today/tomorrow with a few other PRs.