decap-cms icon indicating copy to clipboard operation
decap-cms copied to clipboard

Published 20 hours ago • verified publisher icon decaporg

Unminified.js

Open mmkal opened this issue 3 years ago • 5 comments

Fixes #6104

Not ready yet but CC @erezrokah

Summary

Produces unminified js.

Test plan

  • [ ] yarn build in netlify-cms-core, it works and produces the right files
  • [ ] yarn build in the repo root

Checklist

Please add a x inside each checkbox:

  • [x] I have read the contribution guidelines.
  • [ ] Code is formatted via running yarn format.
  • [ ] Tests are passing via running yarn test.
  • [ ] The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)

best I can do is 🐈

mmkal avatar Jan 21 '22 15:01 mmkal

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '23 09:04 stale[bot]

@martinjagodic I'd still like a solution to #6104 but I imagine this is out of date now - are you planning on sticking with webpack + a custom build config? I would have thought in 2023 and with the significant netlify->decap overhaul it'd be better to switch to something like microbundle which can take care of pretty much everything without worrying much about configuration. Or, use turbopack in anticipation of it getting out of beta and becoming the de-facto webpack successor (usually a good idea to bet on Vercel!).

If you disagree, feel free to reopen this and I may be able to find some time to fix up the build.

mmkal avatar May 22 '23 11:05 mmkal

Yes, we need unminified JS. I believe that build tools are not on the radar yet. @demshy do you have any comments on this? I guess we will have to revisit this soon.

martinjagodic avatar May 22 '23 11:05 martinjagodic

Deploy Preview for decap-www canceled.

Name Link
Latest commit 8996818ac305a004cb53acfa3e1e742e70d17b74
Latest deploy log https://app.netlify.com/sites/decap-www/deploys/646b5458aa63a400073e77d6

netlify[bot] avatar May 22 '23 11:05 netlify[bot]

Ok, I've reopened and updated. If it goes green I can't see any great harm in it going in like this, the build tools could always be updated afterwards. Over a year ago I said it wasn't ready, I don't remember what was missing exactly but maybe not much.

mmkal avatar May 22 '23 11:05 mmkal