ViperMonkey icon indicating copy to clipboard operation
ViperMonkey copied to clipboard

Python3 compatibility

Open zaddach opened this issue 6 years ago • 2 comments

Hi,

I've started a first attempt at Python3 compatibility for ViperMonkey. It's running currently working with one test document (.doc), but I'm sure that there are some strings I haven't converted to bytes if you use different file formats (.docx, .xls, .ppt). If you would rather have this in a separate branch (e.g., python3), I can re-create the PR against that branch.

Addresses #69.

  • Jonas

zaddach avatar Nov 21 '19 12:11 zaddach

Thanks a lot Jonas. Looking at the changes, they may break python 2 compatibility. So yes, please use a separate python3 branch so that we can work on it while the master branch still runs on python 2.

decalage2 avatar Nov 21 '19 20:11 decalage2

Thank you @zaddach for your work! @decalage2 what is missing to switch to Python3? Dependent libraries would like to update ;)

reneleonhardt avatar Jun 12 '23 03:06 reneleonhardt