Jarvis icon indicating copy to clipboard operation
Jarvis copied to clipboard

Published 20 hours ago • verified publisher icon debugger22

Remove api key

Open jyotiska opened this issue 10 years ago • 6 comments

Removed api key from the google_stt.py to prevent others from abusing the API_key.

jyotiska avatar May 17 '14 10:05 jyotiska

It could be worth adding the API key to the config file :)

srizzling avatar May 17 '14 13:05 srizzling

It'd be nice if there was some sort of public key that we could use for the entire app, especially for people that don't have keys (like me). But, I think if its possible to abuse the key, good pr. :+1:

brendanashworth avatar May 17 '14 15:05 brendanashworth

+1. You should also give a prompt if API key is not available and yeah a config file would be great.

debugger22 avatar May 17 '14 17:05 debugger22

My suggestion is - do not expose your own API key to public. People should use their own API key if they want to use or build something with this app. I do not think google will let us use one universal public API key for this app. So, for now, let users use their own API key.

jyotiska avatar May 17 '14 18:05 jyotiska

That's what I'm saying. I just want that let users put API key in a config file rather than the source code.

debugger22 avatar May 17 '14 18:05 debugger22

There is already a config fille which you can use. +1 for an exception if the user does not have an API key :)

srizzling avatar May 17 '14 23:05 srizzling