cli icon indicating copy to clipboard operation
cli copied to clipboard

add option to generate a new fingerprint file or not.

Open AntonDebricked opened this issue 1 year ago • 4 comments

AntonDebricked avatar Jul 12 '24 13:07 AntonDebricked

lgtm! Does this change the default behaviour and is that something we want? Since before rerunning would generate new ones right?

ProgHaj avatar Aug 01 '24 08:08 ProgHaj

lgtm! Does this change the default behaviour and is that something we want? Since before rerunning would generate new ones right?

The previous behavior was to always overwrite the file named debricked.fingerprints.txt. The default behavior will be the same as before (overwrite file)

ghost avatar Aug 05 '24 08:08 ghost

Please wait with merge, @sweoggy wanted to have the chance to comment on the naming convention for the new fingerprint files.

ghost avatar Aug 05 '24 08:08 ghost

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.35 -> 9.35)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

  • Complex Method fingerprint.go: FingerprintFiles 🔥

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]