scala-redis icon indicating copy to clipboard operation
scala-redis copied to clipboard

Upgrade Apache Commons Pool to version 2.5?

Open jgdodson opened this issue 7 years ago • 3 comments

Would this be a welcome change? The current version used is 1.6. Version 2.x (2.5 is most recent) has some performance and scalability improvements. I looked over the docs, and the requisite changes would be minimal. I'd be happy to knock this out.

jgdodson avatar Mar 26 '18 05:03 jgdodson

+1 .. feel free to send over a PR ..

debasishg avatar Mar 26 '18 05:03 debasishg

On closer inspection, I've realized that this update will require an annoyingly small change to the constructor of RedisClientPool, so this will need to be placed on the 4.x track, if that's even planned.

jgdodson avatar Mar 28 '18 01:03 jgdodson

👍

debasishg avatar Mar 28 '18 04:03 debasishg