scala-redis-nb icon indicating copy to clipboard operation
scala-redis-nb copied to clipboard

Use Queue API instead of inefficient operations

Open okumin opened this issue 10 years ago • 4 comments

In Scala 2.10.x, Queue#:+ has a performance issue. https://github.com/scala/scala/commit/f0f0a5e7813501d985174d3c5573c34c8a7608c6

So this commit replaces that operations with Queue#enqueue. And use Queue#dequeue explicitly instead of Queue#head and Queue#tail. There is little dirrerence between these operations, but it will be obvious that Queue is used correctly.

okumin avatar Sep 16 '14 17:09 okumin

When I tried to request too many commands, Queue#:+ in ResponseHandling spent much time.

okumin avatar Sep 23 '14 19:09 okumin

Thanks .. I will take a look and merge ASAP.

debasishg avatar Sep 23 '14 19:09 debasishg

I found another bottleneck……, so I'm going to fix that.

okumin avatar Sep 24 '14 07:09 okumin

It is difficult to fix, so created the issue. https://github.com/debasishg/scala-redis-nb/issues/104

okumin avatar Sep 24 '14 08:09 okumin