jupyterlab-deck
jupyterlab-deck copied to clipboard
Jupyterlab>4.1
Update compatibility to jupyterlab>=4.1, and update dependencies accordingly, the keyboard shortcuts are not compatible starting from version 4.1.0.
Checklist
- [ ] ran
doit lintlocally
References
Related to https://github.com/deathbeds/jupyterlab-deck/issues/63
Code changes
- [x] switch to 'no windowing' mode, and update some CSS rules on notebook node.
When the notebook changes to full windowed mode (the default since lab 4.1) some CSS rules are applied to the viewport node, and are not properly removed when switching back to 'no windowing' mode. These rules should be fixed upstream in Jupyterlab, but are also fixed here for backward compatibility.
- The rule applied on
.jp-WindowedPanel-innerhas been fixed in lab 2.2 with https://github.com/jupyterlab/jupyterlab/pull/16383 - Another rule applied to
.jp-WindowedPanel-viewportshould be fixed with https://github.com/jupyterlab/jupyterlab/pull/16979#issuecomment-2488544599
- The rule applied on
- [x] update the background rule with the new
.jp-ThemedContainer - [x] fix the keyboard shortcut
User-facing changes
None
Backwards-incompatible changes
None
Hello!
Thanks a lot @brichet for this MR! Any chances to have it reviewed and merged sometime soon? The semester is about to start and this is blocking us from upgrading Jupyterlab to > 4.0.
Thank you in advance,