markdownload icon indicating copy to clipboard operation
markdownload copied to clipboard

Published 20 hours ago • verified publisher icon deathau

Resolve Obsidian Filename Determination Issue in background.js

Open nekton39 opened this issue 1 year ago • 2 comments

Description

This pull request addresses the Obsidian integration issue related to filename determination in the background.js file. The problem was identified in the use of article.title, which did not adhere to the "Template for title/filename" setting. The fix involves replacing article.title with await formatTitle(article), ensuring proper alignment with user configuration preferences.

Changes Made

  • Modified Obsidian integration logic in background.js: replaced article.title with await formatTitle(article).

Issue Reference

Closes #289

nekton39 avatar Feb 05 '24 23:02 nekton39

LGTM

quanru avatar Apr 29 '24 02:04 quanru

@deathau Is it convenient to merge?

quanru avatar Jul 16 '24 01:07 quanru

3.4.0 still doesn't work. Did you forget to build it?

quanru avatar Sep 02 '24 05:09 quanru