markdownload icon indicating copy to clipboard operation
markdownload copied to clipboard

On certains websites `{{baseURI}}` returns the wrong URI

Open nicolaiarocci opened this issue 2 years ago • 3 comments

How to reproduce:

  1. Got to https://steven-giesel.com/blogPost/79ce95ad-17a9-4537-8f1b-48d71efc585d
  2. Hit the extension icon
  3. My result for the 'source' tag in the front matter is moz-extension://d880f626-c6d9-4776-b1a6-a717e26d44eb/, while the expected result would be the page url above

image

nicolaiarocci avatar Dec 30 '22 10:12 nicolaiarocci

I have the same problem; so far I've only noticed it with GitHub. For this issue, instead of https://github.com/deathau/markdownload/issues/201 I get chrome-extension://pcmpcfapbekmbjjkdalcgopdkipoggdi/_generated_background_page.html (which is the ID of the MarkDownload extension)

Screenshot 2023-02-08 at 4 08 41 PM

And at the bottom of the generated markdown is a bunch of error text: Screenshot 2023-02-08 at 4 08 54 PM

---
[](https://github.com/Nezteb)

[Skip to content](chrome-extension://pcmpcfapbekmbjjkdalcgopdkipoggdi/_generated_background_page.html#start-of-content)

![[/3588798.jpeg]]

Sorry, something went wrong.

deathau  /   markdownload  /   Issues #201  /  

Tip: Type # to search pull requests

Tip: Type # to search issues

Tip: Type # to search discussions

Tip: Type ! to search projects

Tip: Type @ to search teams

Tip: Type @ to search people and organizations

Tip: Type \> to activate command mode

Tip: Go to your accessibility settings to change your keyboard shortcuts

Tip: Type author:@me to search your content

Tip: Type is:pr to filter to pull requests

Tip: Type is:issue to filter to issues

Tip: Type is:project to filter to projects

Tip: Type is:open to filter to open content

We’ve encountered an error and some results aren't available at this time. Type a new search or try again later.

No results matched your search

Commands Type > to filter

Global Commands Type > to filter

Issues, pull requests, and discussions Type # to filter

Use filters in issues, pull requests, discussions, and projects

Search for **issues** and **pull requests** # Search for **issues, pull requests, discussions,** and **projects** # Search for **organizations, repositories,** and **users** @ Search for **projects** ! Search for **files** / Activate **command mode** \> Search your issues, pull requests, and discussions \# author:@me Search your issues, pull requests, and discussions \# author:@me Filter to pull requests \# is:pr Filter to issues \# is:issue Filter to discussions \# is:discussion Filter to projects \# is:project Filter to open issues, pull requests, and discussions \# is:open

You can’t perform that action at this time.

[](https://github.com/deathau/markdownload/tree/master?search=1)

Nezteb avatar Feb 09 '23 00:02 Nezteb

Also experiencing this issue. I think I've narrowed it down to Readability.js, at some point the dom.baseURI changes from the correct value to the extension's URL. This also affects relative URLs in images (#260).

zaxbux avatar Dec 08 '23 10:12 zaxbux

Should be addressed by pull request #308

WetHat avatar Mar 28 '24 10:03 WetHat