Missing/Black textures in SSB Planet Zebes

[weinerschnitzel]

If you play Planet Zebes in Super Smash Bros you can notice some textures missing on the floor and on the moving platform. This may take a few seconds for the issue to become apparent.

I think it is related to a memory leak noticed in SSB and texture code here: https://github.com/death-droid/Rice-Video/blob/master/Texture/TextureManager.cpp#L451

Removing that code will make the texture glitches go away, but I think the issue is deeper.

[death-droid]

Hmm interesting, thanks for the heads up on that. Will have to look into this

[LegendOfDragoon]

I think this issue is fixed. I have not seen it in the latest version I compiled, nor the older ones. I'm going through the commit history, trying to track down improvements and regressions.

I'd love to find out how to fix the border issue which is apparent in these screenshots.

[weinerschnitzel]

Thanks for the investigative work @LegendOfDragoon. @Salvy referred to some code they use in Daedalus: https://github.com/death-droid/Rice-Video/issues/5#issuecomment-52276089 But wasn't that your issue thread?

[LegendOfDragoon]

@weinerschnitzel I couldn't get it to work, unfortunately.

[weinerschnitzel]

With the block of code that causes this, what is the slowdown you were referring to?

[LegendOfDragoon]

Weird, im not sure why I thought it was fixed. It's still present. Rice 6.1.0 does not have this issue, so it must be a regression.

[weinerschnitzel]

Its that code addition. Ill make a commit removing it if deathdroid approves.

[LegendOfDragoon]

i'd like to test the code, can u hop on irc?

[weinerschnitzel]

Not right now unfortunately. I can in about 5 hours though