perf_event_tests icon indicating copy to clipboard operation
perf_event_tests copied to clipboard

Add rdpmc tests using libperf

Open Nakamura-Shunsuke opened this issue 3 years ago • 4 comments

I will add rdpmc tests using libperf since libperf now supports rdpmc. These tests are based on perf_event_tests/tests/rdpmc, which assumes that libperf is installed in the /usr/local/lib/ directory.

install command :

git clone https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
cd linux
make -C tools/lib/perf/ DESTDIR=/usr/local/lib/libperf/ install

Nakamura-Shunsuke avatar Nov 24 '21 07:11 Nakamura-Shunsuke

@deater ,Is there any missing information to merge the pull requests? I would appreciate it if you could comment on it.

Nakamura-Shunsuke avatar Dec 15 '21 08:12 Nakamura-Shunsuke

@deater , Do you have any comments? If there is no problem, Would you please merge it if there is no problem?

Nakamura-Shunsuke avatar Jan 04 '22 07:01 Nakamura-Shunsuke

While I like the idea, I don't think duplicating the tests is a good idea.

robherring avatar Jan 20 '22 20:01 robherring

@robherring , Thank you for your comment.

While I like the idea, I don't think duplicating the tests is a good idea.

Do you mean that I should add tests using libperf to the existing source code in tests/rdpmc instead of creating a new tests/rdpmc_libperf? Or does it mean that adding the same test case is not desirable?

Nakamura-Shunsuke avatar Jan 26 '22 09:01 Nakamura-Shunsuke