omgosc icon indicating copy to clipboard operation
omgosc copied to clipboard

Published 20 hours ago • verified publisher icon deanm

adding sender info to params array of the receiver

Open charlieroberts opened this issue 11 years ago • 5 comments

Having the IP address of the OSC sender is really useful if you're expecting multiple clients. Would be great if you'd be willing to pull this in and push to npm so I don't have to make a duplicate package for this one line of code.

Thanks for a great library!

charlieroberts avatar Sep 19 '14 19:09 charlieroberts

Sorry, I don't see any changes to the processMessageOrBundle definition in this pull request, is the commit for that not included?

screenshot

deanm avatar Sep 19 '14 21:09 deanm

It's the change in green in the image included with your last comment. I added a info:rinfo field to the event object on line 246.

Let me know if I'm confused... - Charlie

charlieroberts avatar Sep 19 '14 23:09 charlieroberts

I was asking where is the change to the signature of processMessageOrBundle, how does rinfo get passed from the udp message callback into processMessageOrBundle? I don't see anything related to this in your pull request.

The screenshot I posted is the entire change within this pull request, not just a portion of it.

deanm avatar Sep 20 '14 07:09 deanm

Sorry, that was completely boneheaded of me; I had made these changes in a different project a long time ago and forgotten about them. I tested this commit and it works fine.

charlieroberts avatar Sep 22 '14 20:09 charlieroberts

Thanks. There are two things.

  1. On a quick look, I think this patch is faulty, because you'll notice processMessageOrBundle can be recursive for unpacking bundled messages, and you haven't updated that call, so I believe this wouldn't work correctly for bundled message.

  2. I want to give a little think about the best way to send sender data back on the event, and which data should be sent. I haven't looked at this code in a while, so I have to remember my intentions, since OSC in theory can run over usb, udp, tcp, etc. Maybe it should at least identify that it was from a udp source.

Anyway, I agree with the overall idea of sending back information about the connection, I will give it a think and write up something like this or similar and let you know.

Thanks

deanm avatar Sep 23 '14 11:09 deanm