Upgrading from 1.2 stable to 1.3 RC1 fails

[Turranius]

I just started using osync (love it) and got 1.2 Stable set up with 2 different hosts. One local, one ssh. Initiator is the local server. Everything works fine.

Then I saw that 1.3 RC3 existed and seemed stable enough so I tried upgrading but I get some strange errors on sync that 1.2 does not produce.

Clean 1.2 execution working fine. No .osync_workdir exists on either sites:

RESUME_SYNC=no ./osync.sh --initiator="/glftpd/site" --target="ssh://root@censored//glftpd/site"

TIME: 0 - ------------------------------------------------------------- TIME: 0 - Tue Oct 25 09:49:46 CEST 2022 - osync 1.2 script begin. TIME: 0 - ------------------------------------------------------------- TIME: 0 - Sync task [quicksync_task] launched as root@censored (PID 721899) TIME: 1 - Checking minimum disk space in local replica [/glftpd/site/]. TIME: 0 - Checking minimum disk space in remote replica [/glftpd/site/]. TIME: 3 - Starting synchronization task. TIME: 3 - Creating initiator replica file list [/glftpd/site/]. TIME: 3 - Creating target replica file list [/glftpd/site/]. TIME: 52 - Creating initiator replica deleted file list. TIME: 52 - Creating target replica deleted file list. TIME: 53 - Updating target replica. TIME: 92 - Updating target replica succeded. TIME: 92 - Updating initiator replica. TIME: 134 - Updating initiator replica succeded. TIME: 134 - Propagating deletions to initiator replica. TIME: 134 - Propagating deletions to target replica. TIME: 136 - Creating initiator replica file list [/glftpd/site/]. TIME: 136 - Creating target replica file list [/glftpd/site/]. TIME: 185 - Finished synchronization task. TIME: 185 - Running conflict backup cleanup. TIME: 186 - Removing files older than 30 days on target replica for conflict backup deletion. TIME: 186 - Cleanup complete on target replica. TIME: 186 - Running soft deletion cleanup. TIME: 186 - Removing files older than 30 days on initiator replica for softdelete deletion. TIME: 186 - File cleanup complete on initiator replica. TIME: 186 - Directory cleanup complete on initiator replica. TIME: 187 - Removing files older than 30 days on target replica for softdelete deletion. TIME: 187 - Cleanup complete on target replica. TIME: 188 - osync finished.

Now lets delete the .osync_workdir on both sites and try 1.3 RC3

RESUME_SYNC=no osync.sh --initiator="/glftpd/site" --target="ssh://root@censored//glftpd/site"

TIME: 1 - ------------------------------------------------------------- TIME: 1 - Tue Oct 25 09:54:58 CEST 2022 - osync 1.3.0-rc3 script begin. TIME: 1 - ------------------------------------------------------------- TIME: 1 - Sync task [quicksync_task] launched as root@censored (PID 736300) TIME: 1 - Created local replica osync path [/glftpd/site//.osync_workdir]. TIME: 1 - Checking minimum disk space in local replica [/glftpd/site/]. RTIME: 0 - Created local replica osync path [/glftpd/site//.osync_workdir]. RTIME: 0 - Checking minimum disk space in remote replica [/glftpd/site/]. TIME: 3 - Starting synchronization task. TIME: 3 - Creating initiator replica file list [/glftpd/site/]. TIME: 3 - Creating target replica file list [/glftpd/site/]. TIME: 4 - Some files could not be listed in target replica [/glftpd/site/]. Check for failing symlinks. TIME: 4 - Truncated output: rsync: [sender] change_dir "/root/'/glftpd/site" failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1839) [Receiver=3.2.6] rsync: [Receiver] write error: Broken pipe (32) TIME: 19 - Creating initiator replica deleted file list. TIME: 19 - Creating target replica deleted file list. TIME: 20 - Updating target replica. TIME: 20 - Updating target replica failed. Stopping execution. TIME: 20 - Truncated rsync output: rsync: [Receiver] mkdir "/root/'/glftpd/site/'" failed: No such file or directory (2) rsync error: error in file IO (code 11) at main.c(780) [Receiver=3.2.6] TIME: 20 - _ExecTasksPidsCheck called by [Sync_syncUpdate_target] finished monitoring pid [738433] with exitcode [1]. TIME: 21 - osync finished with errors.

Two things 1: What is "rsync: [sender] change_dir "/root/'/glftpd/site" failed: No such file or directory (2)" That path is all wrong. Where does the /root/ come from? It should be /glftpd/site only.

2: I get broken pipe on rsync. Does not happen with 1.2. Sometimes it starts syncing a few files before I get a broken pipe again.

I did verify that there are no symlinks, as it suggests I do, with "find /glftpd -type l" but nope, there are none so that is not it.

Going back to 1.2 works fine.

Environment (please complete the following information):

• 1.2 Stable vs 1.3 RC3 2021062901
• OS: Fedora Server 36
• Bitness: x64
• Shell: bash
• rsync --version: rsync version 3.2.6 protocol version 31

[Turranius]

I also tried it with SSH_CONTROLMASTER=false but that made no difference. Checking CHANGELOG =)

[Turranius]

This case can probably be closed. Same as with #242 and RSYNC_OLD_ARGS=1 works fine with 1.3 RC3

[deajan]

I actually started investigating, and that doesn't make sense to me. Same Platform, same rsync version, different outcomes. Mind providing your Platform details ?

[Turranius]

Its a standard Fedora 36 x64 server on both ends. Both updated 100% yesterday.

cat /etc/redhat-release Fedora release 36 (Thirty Six)

uname -a Linux localhost 5.19.16-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Sun Oct 16 22:50:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

rsync --version rsync version 3.2.6 protocol version 31

bash --version GNU bash, version 5.2.2(1)-release (x86_64-redhat-linux-gnu)