prometheus-plugs icon indicating copy to clipboard operation
prometheus-plugs copied to clipboard

1.1.5 - warning: System.stacktrace/0 is deprecated, use __STACKTRACE__ instead

Open dylan-chong opened this issue 4 years ago • 1 comments

use Prometheus.PlugPipelineInstrumenter

The code above triggers the following warning:

warning: System.stacktrace/0 is deprecated, use __STACKTRACE__ instead

on Elixir 1.11[.2].

This is a problem because we use mix compile --warnings-as-errors in our CI to prevent developer mistakes/warnings seeping into master, which means our CI builds fail because of this warning.

Looks like you can also mark the macro code as generated to supress warnings https://github.com/elixir-lang/elixir/blob/b889975c5574d9edd679ecf55c6707e3eb1f51d1/lib/ex_unit/lib/ex_unit/assertions.ex#L710

dylan-chong avatar Jan 04 '21 20:01 dylan-chong

Ok so this looks fixed in Prometheus https://github.com/deadtrickster/prometheus.ex/commit/dea38d0b2c8edc2c8c97979f42f06d48135a12b6.

dylan-chong avatar Jan 05 '21 01:01 dylan-chong