prometheus-phoenix icon indicating copy to clipboard operation
prometheus-phoenix copied to clipboard

New telemetry handler for phoenix 1.5+ projects

Open nurugger07 opened this issue 5 years ago • 10 comments
trafficstars

Greetings @deadtrickster!

I hope all is well. I have created a project called prometheus-phx that handles the telemetry changes in phoenix 1.5. I would be happy to contribute those changes back to this project but they would be breaking changes and require a major version bump. I'm not sure what your preference would be moving forward. Do you still want to continue maintaining this project? Would you want to transfer the project? Looking forward to hearing from you :)

For those interested here is a link to the new project: https://github.com/theblitzapp/prometheus-phx

It's not a hex package yet because I'm waiting the preferred direction from deadtrickster

nurugger07 avatar Sep 15 '20 16:09 nurugger07

Yes, I would gladly accept contribution

deadtrickster avatar Sep 17 '20 11:09 deadtrickster

Would love to see this released in some form. Not the maintainer, but a major version bump with some notes on which version of the package is compatible with which version of Phoenix Framework should be enough?

oohnoitz avatar Oct 20 '20 01:10 oohnoitz

yes of course that would be enough

deadtrickster avatar Oct 20 '20 20:10 deadtrickster

@nurugger07 are you still working on this? I would love to see your changes merged into this library as well.

davidkovsky avatar Oct 27 '20 20:10 davidkovsky

@nurugger07 maybe we can help you somehow?

deadtrickster avatar Nov 23 '20 18:11 deadtrickster

FWIW, @nurugger07's repo works well in production so far and it's likely the adjustments just need to be copied over if he's preoccupied.

astjohn avatar Feb 14 '21 15:02 astjohn

Sorry, things have been a bit crazy lately but I'll get this wrapped up this week

nurugger07 avatar Feb 16 '21 21:02 nurugger07

Got a WIP PR up so that @deadtrickster could begin the review process. Still need to update docs and add some additional functionality

nurugger07 avatar Feb 25 '21 03:02 nurugger07

@nurugger07 looking at your implementation for some of our use cases, what help is required to get this merged in?

smn avatar May 24 '21 15:05 smn

@nurugger07 i am also waiting for this change

djschilling avatar Jun 18 '21 14:06 djschilling