Acode icon indicating copy to clipboard operation
Acode copied to clipboard

Plugin Dependencies

Open alMukaafih opened this issue 1 year ago • 3 comments

alMukaafih avatar Sep 06 '24 18:09 alMukaafih

have you tested it? It doesn't work. You need to properly handle the paid plugin cases etc

bajrangCoder avatar Sep 10 '24 14:09 bajrangCoder

I have tested it and it works for both free and paid plugins though further testing is needed for paid plugins

alMukaafih avatar Oct 13 '24 19:10 alMukaafih

I have tested it and it works for both free and paid plugins though further testing is needed for paid plugins

Now it's working fine. Just one thing left: It should show the name of plugin which is installing in loader and also before installing the dependencies it's nice to show the user that it's going to install these plugins too.

bajrangCoder avatar Oct 14 '24 08:10 bajrangCoder

I have tested it and it works for both free and paid plugins though further testing is needed for paid plugins

Now it's working fine. Just one thing left: It should show the name of plugin which is installing in loader and also before installing the dependencies it's nice to show the user that it's going to install these plugins too.

Sorry for the late response, was facing some issues irl.

I am deliberately either to show an alert for the dependencies that are going to be installed or a confirmation. Something like

alert(
    "Installer Notice",
    "Acode is going to install the following dependencies<br/>"
      + plugin.dependencies.join("<br/>"),
    () => {
        // Resolve dependencies
    },
);

Or

const shouldInstall = await confirm(
    "Installer Notice",
    "Acode is going to install the following dependencies<br/>"
      + plugin.dependencies.join("<br/>"),
);

if (shouldInstall) {
    // Resolve dependencies 
}

alMukaafih avatar Dec 26 '24 11:12 alMukaafih

Use confirmation

bajrangCoder avatar Dec 26 '24 11:12 bajrangCoder

Use confirmation

Ok 👍

alMukaafih avatar Dec 26 '24 11:12 alMukaafih