cargo-deadlinks icon indicating copy to clipboard operation
cargo-deadlinks copied to clipboard

Find a way to deal with 429 Too Many Requests

Open jyn514 opened this issue 4 years ago • 3 comments

When validating a lot of URLs with --check-http, it's common to get '429 Too Many Requests'. It would be great to be able to ignore these. Alternatively, maybe cargo-deadlinks could add a rate-limit option that avoids getting the error in the first place.

jyn514 avatar Aug 17 '20 21:08 jyn514

This is a hard thing to fix in a general way because different rate limits (if they have any at all).

ayazhafiz avatar Sep 04 '20 22:09 ayazhafiz

I wonder if https://github.com/deadlinks/cargo-deadlinks/pull/63 mitigates the problem.

zummenix avatar Oct 17 '20 03:10 zummenix

I tested this out by running deadlinks book on https://github.com/rust-lang/rustc-dev-guide/. As expected, it gave a bunch of 429 errors, so unfortunately #63 didn't help (although I haven't tested with an earlier version of deadlinks, so it might be fewer 429s than before).

This is a hard thing to fix in a general way because different rate limits (if they have any at all).

Right, this is why I think --rate-limit should be passed by the user and not hard-coded by deadlinks. Alternatively, deadlinks could give a warning but not fail the request.

jyn514 avatar Jan 05 '21 01:01 jyn514