dotdrop
dotdrop copied to clipboard
fix #431 - directory not ignored with negative pattern
fix #431
The issue lies in the fact we do not ignore directories when there is any negative ignore pattern defined. This is to force the caller to enter the directory and evaluate any potential negative ignore pattern inside it.
See https://github.com/deadc0de6/dotdrop/blob/master/dotdrop/utils.py#L307
- [x] discard empty directory
- [x] static instead of recursive search (construct diff from static tree of both sides and then compare)
- [ ] see if the same applies to the other commands
- [x] compare
- [ ] install
- [ ] update
- [ ] import
Codecov Report
Attention: 20 lines in your changes are missing coverage. Please review.
Comparison is base (
de05935) 89.81% compared to head (31e466e) 91.02%.
| Files | Patch % | Lines |
|---|---|---|
| dotdrop/updater.py | 78.84% | 11 Missing :warning: |
| dotdrop/importer.py | 87.23% | 6 Missing :warning: |
| dotdrop/comparator.py | 94.28% | 2 Missing :warning: |
| dotdrop/dotdrop.py | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 89.81% 91.02% +1.20%
==========================================
Files 21 22 +1
Lines 4791 4746 -45
==========================================
+ Hits 4303 4320 +17
+ Misses 488 426 -62
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
install and uninstall won't use the new ftree since those are handling a lot more than just copying/removing files (backups, transformations, etc).