Devdutt Shenoi

We are working on making time for the review(running low on bandwidth), post that we should be good to go. Would have been wonderful if there were more inputs along...

> I think another good addition would be a non consuming try_wait(&mut self) method on the NotifceFuture. This will make it possible to not block while trying to wait for...

We could make use of something like a `RequestBuilder` which will allow us to code as follows: ```rust let publish = RequestBuilder::publish() .topic("topic") .qos(QoS::AtleastOnce) .payload(b"1231231312") .retain() .properties(_) // v5 only...

It's not a good idea to go forward with using `Filter` and `Message` as they aren't the requests themselves and QoS, retain etc are request params. Something like a `Publish/SubscriptionBuilder`...

Why not the following: ```rust let sub: Subscribe = Subscribe::builder("topic", QoS::AtLeastOnce) // SubscriptionBuilder // v5 only .preserve_retain() .nolocal() .retain_forward_rule(RetainForwardRule::Never) .build(); client.subscribe(sub)?; ```

So if I am not wrong, a `Subscribe` packet can contain multiple `Subscription`s for the same request? In that case`Subscription` could just be used to replace `Filter` term. Plus we...

I get your argument, yet the protocol description distinguishes between **topic filters** and **subscription**. The subscription is a transfer contract between the client and programmer in how it will forward...

> what about the `Message` though? what should we name it then? can't name it `Publish` as it will conflict with publish packet, nor `Publication` cuz sounds weird haha >...

> Let me know if this PR is still relevant for the project. @flxo please note that we value your time and contributions a lot but have been facing a...

Once #845 is merged, would love to see design suggestions for the interface with user. Hopefully with the implementation as well.