Daniel Dybing

Results 34 comments of Daniel Dybing

This should be working as expected now, just tested in 0.25.5 :)

I've submitted a PR https://github.com/toeverything/AFFiNE/pull/13975 to fix.

The fix has been merged and is available in the canary channel. I assume it will be available in the next stable update.

Perhaps related to the newer version of Electron used in 0.25.5?

@darkskygit Sorry, should be fixed now. Had forgotten to add the searchAlias property to the TextConversionConfig interface.

Test is expecting 4 properties, but the object now has 5. Do we update the tests, or should I try to find another way to implement this feature?

I have updated e2e test to adjust for the increase in item properties. I will await the result from the build and test workflow.

I see there are still some errors with one of the tests. Shall I look into it @darkskygit ?

Is this still an issue in the latest version?

@darkskygit Close this issue? As it is over a year old and no update.