rmfakecloud icon indicating copy to clipboard operation
rmfakecloud copied to clipboard

New UI for this project

Open zgs225 opened this issue 3 years ago • 23 comments

Hi, I'm working on a new UI for this project. It has several imporvements compares to the original UI. There's a website to preview, you can login in with demo/demo.

Improvement:

  • More beautiful
  • Mobile adapted
  • Display progress while uploading
  • Support upload multiple files
  • i18n supported

Screenshot: Dingtalk_20220909155410

This branch is still in progress:

  • [x] Documents
  • [x] Users: list, create, update, delete
  • [x] Code
  • [x] Reset password
  • [x] Login and logout
  • [x] Download
  • [x] View document
  • [x] Rename document
  • [x] Delete document
  • [x] Create folder
  • [x] Move documents
  • [x] Delete folder
  • [x] Rename folder

zgs225 avatar Sep 09 '22 08:09 zgs225

If someone want to try this PR himeself that can use image yuezzzzzzzzzzz/remarkable-personal-cloud:dev instead of the original image, no other thing need to changes.

zgs225 avatar Sep 16 '22 02:09 zgs225

looks nice. I wanted to have some drag&drop for the files but never got to that

ddvk avatar Sep 21 '22 09:09 ddvk

looks nice. I wanted to have some drag&drop for the files but never got to that

Two new features added: create folder and move documents.

zgs225 avatar Sep 22 '22 02:09 zgs225

Remove folder, rename folder supported

zgs225 avatar Sep 23 '22 07:09 zgs225

@ddvk The PR accomplished, would you like to review?

zgs225 avatar Sep 29 '22 00:09 zgs225

I'll review it when I have some time.

btw, recloud is a trademark I would stick with this project's name

ddvk avatar Oct 08 '22 15:10 ddvk

Ok. I'll change the name to rmfakecloud.

zgs225 avatar Oct 09 '22 11:10 zgs225

The name has changed to rmfakecloud. The logo and favicon have been replaced by a new one too. image

zgs225 avatar Oct 10 '22 03:10 zgs225

So here are some things: sync15 is not implemented i don't like commit hooks running the ui without the backend doesn't show any errors clicking logout just hosws spinner (without a running backend) the ui shows the main/documet page without the user being logged in the build has to be fixed

ddvk avatar Oct 20 '22 06:10 ddvk

Thanks for your advice.

"the ui shows the main/documet page without the user being logged in", The user will redirect to login page if he is not authorized. I implement authentication by API invocation, it can't work without a running backend.

Could you describe more about sync15 implementation?

  • [x] Add error page when without a running backend -> to fix 3, 4, 5
  • [x] Fix build
  • [x] Remove commit hooks
  • [x] Implements sync15

zgs225 avatar Oct 21 '22 02:10 zgs225

sync15 is a new version of the sync. it uses less bandwidth and allows for 2way sync. i've been using it for some time and so far it has worked well, but was not the default.

there is a client implementation in rmapi. I can add the api calls for creating folders and file move/rename

ddvk avatar Oct 21 '22 07:10 ddvk

Hi, @ddvk I have implemented the API for the sync15 backend except for the API for removing documentation. I want to implement it like the below:

Updates value of the property "delete" of blob documentation's metadata to true, then wait device to sync to remove documentation actually.

Can the implementation work properly? It's pleasure to have your advice.

zgs225 avatar Oct 28 '22 01:10 zgs225

I also added the whole sync15 ui apis, let me see how we can merge them

ddvk avatar Oct 28 '22 15:10 ddvk

Ok, I add a new feature to the new UI, it now show different icon by document's type.

zgs225 avatar Oct 28 '22 16:10 zgs225

Hi, I do some efforts to fix make build and make all. By now, all review issues have been resolved. Would you like to do a second review?

These potential problems found by the github-code-scanning bot could be a false positive report, do these have to be fixed?

zgs225 avatar Oct 29 '22 04:10 zgs225

I gave this new UI a try recently and just wanted to say: nice job. Haven't found any issues, uploading and organizing documents all worked smoothly. Great contribution, thanks @zgs225 !

dominikandreas avatar Nov 06 '22 15:11 dominikandreas

yes, the codeql are false positive.

ddvk avatar Nov 06 '22 21:11 ddvk

Hey! This UI looks nice. But this didn't get the attention it deserved. @zgs225, could you solve the conflicts that recently arose? And @ddvk, would you mind reviewing this to merge it when ready?

Gamer92000 avatar Dec 26 '22 21:12 Gamer92000

@Gamer92000 it's on my todo list. i'll even fix the conflict, but haven't had time

ddvk avatar Dec 26 '22 21:12 ddvk

Sounds good! :+1:


Dann wünsche ich noch einen schönen Rest-Stephanstag :P

Gamer92000 avatar Dec 26 '22 21:12 Gamer92000

Any update on this? I'd like to use this new shiny UI. It seems to be a great improvement in usability.

nopper avatar Jul 09 '23 17:07 nopper

Any update on this? I'd like to use this new shiny UI. It seems to be a great improvement in usability.

I appreciate your interest in the new UI. I want to assure you that I will make an effort to continue working on it, but I cannot guarantee a specific timeframe for its completion.

zgs225 avatar Jul 11 '23 01:07 zgs225