David Duponchel

Results 31 comments of David Duponchel

Reading encrypted zip files sounds good ! I'm ok with not supporting PKWARE strong encryption since the specification says ``` The Strong Encryption technology defined in this specification is covered...

And you don't have to update the `dist/*` files, they are updated before each release :-)

Yes, with the `checkCRC32` option, everything is decompressed. The idea was to be able to check the validity of a zip file (and the crc32 values with this option) with...

A `zipObj.encrypted` and extended errors sound good ! For the `onError` (5 days ago, I'm a bit late) : it may be too weird to have a synchonous method returns...

Thanks for the pull request. - Could you add unit tests (after [this one](https://github.com/Stuk/jszip/blob/c978642a61594ed92088248edc9796567eccce41/test/asserts/file.js#L691) for example, in the "about folders" module) ? - Could you also update the documentation ?...

It seems you edited the issue without changing the title (the issue doesn't have anything to do with "zip.generateAsync is not a function"). `zip.gen.generateAsync` seems strange, there is no `gen`...

That looks like an issue with the type of an object, not the content of the input file. I think you could use any content to trigger the issue. `zip.file(dbFilePath)`...

Your code, on its own, works. I think the issue appears in some use cases with angular4/electron. To understand what's going on, **I need to reproduce the error on my...

This happens because your for-loop doesn't wait and goes from 0 to 100% _before_ calling `zip.generateAsync`. In your case, you should use the [`onUpdate`](http://stuk.github.io/jszip/documentation/api_jszip/generate_async.html) callback: ``` js for(var a=0; a...

> That's probably because the for loops takes a long time to be finished rather than the time spent on `zip.generateAsync` You can check it with [`console.time`](https://developer.mozilla.org/en-US/docs/Web/API/Console/time)/[`console.timeEnd`](https://developer.mozilla.org/en-US/docs/Web/API/Console/timeEnd) or with js...