bstfun icon indicating copy to clipboard operation
bstfun copied to clipboard

2023 fall hackathon bstfun unit testing

Open stl2137 opened this issue 1 year ago • 0 comments

Additional unit testing has been implemented for functions that were only partially tested (per the report from covr::report()). Per report, there should be around 5% more coverage. In addition, functions within the package that previously did not have testing files now do; all functions within bstfun should have a test file. All these changes were performed at the 2023 fall hackathon (10/11 & 10/12).


Reviewer Checklist (if item does not apply, mark is as complete)

  • [ ] Ensure all package dependencies are installed by running renv::install()
  • [ ] PR branch has pulled the most recent updates from main branch. Ensure the pull request branch and your local version match and both have the latest updates from the main branch.
  • [ ] If a new function was added, function included in _pkgdown.yml
  • [ ] If a bug was fixed, a unit test was added for the bug check
  • [ ] Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • [ ] Code coverage is suitable for any new functions/features. Review coverage with withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report()). Begin in a fresh R session without any packages loaded.
  • [ ] R CMD Check runs without errors, warnings, and notes
  • [ ] usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into main:

  • [ ] Update NEWS.md with the changes from this pull request under the heading "# bstfun (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • [ ] Increment the version number using usethis::use_version(which = "dev")
  • [ ] Run codemetar::write_codemeta()
  • [ ] Run usethis::use_spell_check() again
  • [ ] Approve Pull Request
  • [ ] Merge the PR. Please use "Squash and merge".

stl2137 avatar Oct 18 '23 14:10 stl2137