node-segfault-handler icon indicating copy to clipboard operation
node-segfault-handler copied to clipboard

Error when building on electron

Open getchardy opened this issue 3 years ago • 2 comments

With certain versions of NodeJS, we are encountering errors when rebuilding this dependency using electron-builder:

It works in Node 16.3

Does not work in Node 16.16:

• electron-builder  version=22.11.7 os=21.5.0
  • loaded configuration  file=/var/folders/63/sz2y_mcj6jl0kcxtd8szkckc0000gp/T/tmp-28175-BXEvpGscumnI
  • author is missed in the package.json  appPackageFile=/Users/chardy/code/project/src/package.json
  • writing effective config  file=release/development/builder-effective-config.yaml
  • rebuilding native dependencies  [email protected] platform=darwin arch=arm64
  • rebuilding native dependency  name=segfault-handler version=1.3.0
  ⨯ cannot execute  cause=exit status 1
                    out=$ node-gyp rebuild
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

                    errorOut=gyp info it worked if it ends with ok
    gyp info using [email protected]
    gyp info using [email protected] | darwin | arm64
    gyp info find Python using Python version 3.8.9 found at "/Applications/Xcode.app/Contents/Developer/usr/bin/python3"
    gyp info spawn /Applications/Xcode.app/Contents/Developer/usr/bin/python3
    gyp info spawn args [
    gyp info spawn args   '/Users/chardy/.nvm/versions/node/v16.16.0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
    gyp info spawn args   'binding.gyp',
    gyp info spawn args   '-f',
    gyp info spawn args   'make',
    gyp info spawn args   '-I',
    gyp info spawn args   '/Users/chardy/code/project/src/node_modules/segfault-handler/build/config.gypi',
    gyp info spawn args   '-I',
    gyp info spawn args   '/Users/chardy/.nvm/versions/node/v16.16.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
    gyp info spawn args   '-I',
    gyp info spawn args   '/Users/chardy/.electron-gyp/11.5.0/include/node/common.gypi',
    gyp info spawn args   '-Dlibrary=shared_library',
    gyp info spawn args   '-Dvisibility=default',
    gyp info spawn args   '-Dnode_root_dir=/Users/chardy/.electron-gyp/11.5.0',
    gyp info spawn args   '-Dnode_gyp_dir=/Users/chardy/.nvm/versions/node/v16.16.0/lib/node_modules/npm/node_modules/node-gyp',
    gyp info spawn args   '-Dnode_lib_file=/Users/chardy/.electron-gyp/11.5.0/<(target_arch)/node.lib',
    gyp info spawn args   '-Dmodule_root_dir=/Users/chardy/code/project/src/node_modules/segfault-handler',
    gyp info spawn args   '-Dnode_engine=v8',
    gyp info spawn args   '--depth=.',
    gyp info spawn args   '--no-parallel',
    gyp info spawn args   '--generator-output',
    gyp info spawn args   'build',
    gyp info spawn args   '-Goutput_dir=.'
    gyp info spawn args ]
    gyp: name 'openssl_fips' is not defined while evaluating condition 'openssl_fips != ""' in binding.gyp while trying to load binding.gyp
    gyp ERR! configure error 
    gyp ERR! stack Error: `gyp` failed with exit code: 1
    gyp ERR! stack     at ChildProcess.onCpExit (/Users/chardy/.nvm/versions/node/v16.16.0/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:261:16)
    gyp ERR! stack     at ChildProcess.emit (node:events:527:28)
    gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)
    gyp ERR! System Darwin 21.5.0
    gyp ERR! command "/Users/chardy/.nvm/versions/node/v16.16.0/bin/node" "/Users/chardy/.nvm/versions/node/v16.16.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
    gyp ERR! cwd /Users/chardy/code/project/src/node_modules/segfault-handler
    gyp ERR! node -v v16.16.0
    gyp ERR! node-gyp -v v9.0.0
    gyp ERR! not ok 
    error Command failed with exit code 1.

getchardy avatar Jul 27 '22 19:07 getchardy

I saw a similar issue reported in https://github.com/nodejs/node-gyp/issues/2673. If I add the following into bindings.gyp then it works:

'variables' : {
    'openssl_fips': '',
}

getchardy avatar Jul 27 '22 19:07 getchardy

Hi. I have a similar issue using Node 18.7.0.

squid-f avatar Sep 04 '22 12:09 squid-f