node-segfault-handler icon indicating copy to clipboard operation
node-segfault-handler copied to clipboard

Published 20 hours ago • verified publisher icon ddopson

Build and test with Travis CI?

Open vielmetti opened this issue 8 years ago • 6 comments

Any interest in getting a build for node-segfault-handler put into Travis CI? In particular, it could be interesting for testing Node 4 as well as doing some kind of integration testing on OS X. If there is, I'll work on a pull request.

vielmetti avatar Sep 16 '15 19:09 vielmetti

Hey @vielmetti that would be fantastic thanks

No9 avatar Sep 24 '15 23:09 No9

Also note it would be great to get some tests for travis to actually run I did an initial one here https://github.com/No9/node-segfault-handler/blob/master/tests/child-test.js But if you have something more in mind then please work away.

No9 avatar Sep 25 '15 00:09 No9

Noting that prebuild Prebuild https://github.com/mafintosh/prebuild would be handy in this area too.

No9 avatar Dec 02 '15 13:12 No9

This would be necessary (as well as with appveyor for windows) for #33, and I'd be happy to help :+1:

maxkorp avatar Dec 14 '15 19:12 maxkorp

Hey @maxkorp I would love to get prebuilds in some shape or other into this. I have found prebuild from @mafintosh "just works" but I haven't seen node-pre-gyp in action although I can see it is used in a lot of projects. Sorry if I have this wrong but it seems like you want to use both prebuild and node-pre-gyp? Can you outline the idea a little more as I don't want to waste anybodies time. Thanks

No9 avatar Dec 14 '15 20:12 No9

saying we build on the CI servers normally (just like we would for testing), and then we can publish them using node-pre-gyp (and tie node-pre-gyp into the install lifecycle). Separately, I have an additional module that helps for building/publishing for node-pre-gyp against electron's headers.

maxkorp avatar Dec 17 '15 22:12 maxkorp