Allowing users to override the request path - V6

Open elliotlarson opened this issue 3 years ago • 3 comments

PR #403 code on top of the V6 branch

Aug 16 '22 04:08 elliotlarson

@ddnexus Do you want me to squash these commits?

Aug 17 '22 15:08 elliotlarson

@elliotlarson Thank you for your fast action and sorry for the lack of feedback on my side. I am in a loooong month and quite overwhelmed by too many new things...

The PR passed the tests, so it is formally OK, however I need a few more days to find some time for it. Thanks

Aug 18 '22 00:08 ddnexus

@ddnexus Oh, no worries. Sounds good 👍

Aug 18 '22 15:08 elliotlarson

@elliotlarson I refactored the v6 branch and it results in a big mess with this PR. If you could create a new PR, adding your commits on top of v6, (or shash them there if you prefer) everything should be cleaner. Thank you.

Dec 14 '22 02:12 ddnexus

@ddnexus Okay, cool. I'll work on that.

Dec 14 '22 22:12 elliotlarson

@ddnexus Oh, no worries. Sounds good 👍

While at it, I didn't find the entry of the new variable in the pagy.rb initializer. Please, could you check that?

Dec 15 '22 00:12 ddnexus

@elliotlarson Thank you. I had a bit of time and I edited it. (6e939a01)

Dec 16 '22 08:12 ddnexus