ddnet icon indicating copy to clipboard operation
ddnet copied to clipboard

Verify ger10 servers button in left refresh button side on browser menu(T-Client idea)

Open mazty47 opened this issue 1 year ago • 4 comments

I think this will good on the client for verify ger10 servers.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with ASan+UBSan or valgrind's memcheck (optional) button

mazty47 avatar Aug 08 '24 00:08 mazty47

If we start hardcoding stuff can we add more? For example:

  • https://wl.reitw.fr/
  • https://tw.fokkonaut.de/

ChillerDragon avatar Aug 17 '24 07:08 ChillerDragon

is there no such field in the masterserver's json that could simply be used for this verification process?

jxsl13 avatar Aug 17 '24 10:08 jxsl13

If we start hardcoding stuff can we add more? For example:

  • https://wl.reitw.fr/

  • https://tw.fokkonaut.de/

I'd not hardcode more.

is there no such field in the masterserver's json that could simply be used for this verification process?

Currently not, but that'd be the correct solution for the general problem: #6808. Not something I want to ask from a first-time contributor though.

heinrich5991 avatar Aug 17 '24 10:08 heinrich5991

It would be nice if the webserver could return some data to the client, telling if he accepted or declined.

For example:

  • You want to IP ban/range ban, you could add this as security measure to your server
  • You are hosting a tournament and want specific players on specific servers due to tournament rules
  • You want the user to OAuth2 first so he can allowlist for this server

We could either use HTTP status codes for this or use a json body response to send this to the client.

Avolicious avatar Aug 17 '24 11:08 Avolicious