ddnet icon indicating copy to clipboard operation
ddnet copied to clipboard

Vulkan: Reset viewport and scissor

Open def- opened this issue 1 year ago • 2 comments

This fixes the graphics bugs for me using MoltenVK: Before: Screenshot 2024-08-07 at 12 50 17 After: Screenshot 2024-08-07 at 10 12 04

Fixes: https://github.com/ddnet/ddnet/issues/8680

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with ASan+UBSan or valgrind's memcheck (optional)

def- avatar Aug 07 '24 07:08 def-

Are you using the latest MoltenVK version?

If so, I'll open a bug report on their repo now

Jupeyy avatar Aug 07 '24 08:08 Jupeyy

[mvk-info] MoltenVK version 1.2.7, supporting Vulkan version 1.2.275. But I see no viewport/scissor related changes after that: https://github.com/KhronosGroup/MoltenVK/blob/main/Docs/Whats_New.md

def- avatar Aug 07 '24 09:08 def-

@def- how do I reproduce the bug?

ChillerDragon avatar Sep 06 '25 10:09 ChillerDragon

Never mind I managed to reproduce. Compile with -DVULKAN=ON then launch the client and change to vulkan in graphics settings. I did that on an m1 mac with macOS 15.4 (24E248). And also see stuff missing in the server browser.

ChillerDragon avatar Sep 06 '25 11:09 ChillerDragon