ddnet
ddnet copied to clipboard
ddnet
Remove standard `cl_overlay_entities` bind
It's both PR and discussion place for it. Newbie player doesn't really need to have such bind by default, they have it in Controls settings page in case if they want to use it
Checklist
- [ ] Tested the change ingame
- [ ] Provided screenshots if it is a visual change
- [ ] Tested in combination with possibly related configuration options
- [ ] Written a unit test (especially base/) or added coverage to integration test
- [ ] Considered possible null pointers and out of bounds array indexing
- [ ] Changed no physics that affect existing maps
- [ ] Tested the change with ASan+UBSan or valgrind's memcheck (optional)
I don't really see any issue with having the bind except for the possibility of accidentally hitting it and not knowing how to turn it off. Personally I think it could stay, but it would be nice to know the motivation for removing it.
i wouldnt really remove it, maybe change it to +toggle ? (even tho that might create the issue of people asking how to have this on for the entire time ^^)
except for the possibility of accidentally hitting it and not knowing how to turn it off.
That's probably the motivation.
Other opinions? It seems like a commonly asked question for new players is "how to fix this?" after they accidentally enabled entities overlay.
It seems like a commonly asked question for new players is "how to fix this?" after they accidentally enabled entities overlay.
Now a common question will be how to enable entities overlay. I'm in favor of showing a hint when entities are on, similar to the ctrl-shift-d hint.
Now a common question will be how to enable entities overlay.
The question will probably come either way, since the pageup hotkey is not discoverable. Do you mean that the question "how to enable the entities overlay" would no longer have an easy answer: "Press the pageup key", but rather "go into settings and bind it"?
@def- What do you think about https://github.com/ddnet/ddnet/pull/8422#issuecomment-2474952086?
In the debug mode there is now a message at the bottom telling users how to turn it off. This is not an option for entities because many players use it all the time and it would just pollute the view. But maybe we can still put it there? Just not all the time so long time players do not get bothered with it.
Could add some new kind of "tutorial" mode. That shows these kind of hints. That mode then has to be turned off with a setting by the player or maybe it could even turn it self off after some time or other condition.
In the debug mode there is now a message at the bottom telling users how to turn it off. This is not an option for entities because many players use it all the time and it would just pollute the view. But maybe we can still put it there? Just not all the time so long time players do not get bothered with it.
So #9664?
