ddev-selenium-standalone-chrome icon indicating copy to clipboard operation
ddev-selenium-standalone-chrome copied to clipboard

Update selenium image to 124.0

Open koehnlein opened this issue 1 year ago • 3 comments

The Issue

The plugin uses a selenium docker image, which is about two years old and contains outdated Chromium version 101

How This PR Solves The Issue

This PR switches to a newer docker image with Chromium version 124. I also thought about using "latest" instead of a specific version. But I decided against it, because this would mean, the users always would use and pull new images with other Chromium versions which would result in unexpected behavior.

Manual Testing Instructions

Update the current plugin in your DDEV settings and execute ddev restart. This will trigger to pull the newer image.

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

koehnlein avatar May 08 '24 10:05 koehnlein

Hanging, just like it did at #31. i dont know the cause.

weitzman avatar May 08 '24 11:05 weitzman

Thanks. I only search in open PRs for duplication

koehnlein avatar May 08 '24 14:05 koehnlein

I think Selenium dropped compatibility with the JSON wire protocol a while back, but supporting the W3C dialect is still a WIP: https://www.drupal.org/project/drupal/issues/3432099.

andriokha avatar May 08 '24 17:05 andriokha

Rebased. Maybe now we will see what happens here when we have artifacts in the GitHub Actions.

stasadev avatar Jul 04 '25 12:07 stasadev

I was able to make the test pass locally when I removed w3c: false in https://github.com/drupal/drupal/blob/10.6.x/core/tests/Drupal/Nightwatch/nightwatch.conf.js

In Drupal 11 this seems not to be hard coded anymore. But because I am not a Drupal guy, I am done at this point. :shrug:

koehnlein avatar Jul 13 '25 19:07 koehnlein

See #49

weitzman avatar Jul 22 '25 01:07 weitzman