ddev-browsersync icon indicating copy to clipboard operation
ddev-browsersync copied to clipboard

Odd header output with ddev-browsersync

Open rfay opened this issue 2 years ago • 1 comments

I happened to be trying out ddev-browsersync with a stock drupal10 umami (macOS, Chrome, DDEV v1.22.3) and saw this stuff all the time at the top. I have no idea whether that has anything to do with this add-on, but wanted to mention it.

, but this code // executes before the first paint, when is not yet present. The // classes are added to so styling immediately reflects the current // toolbar state. The classes are removed after the toolbar completes // initialization. const classesToAdd = ['toolbar-loading', 'toolbar-anti-flicker']; if (toolbarState) { const { orientation, hasActiveTab, isFixed, activeTray, activeTabId, isOriented, userButtonMinWidth } = toolbarState; classesToAdd.push( orientation ? toolbar-+ orientation + `` : 'toolbar-horizontal', ); if (hasActiveTab !== false) { classesToAdd.push('toolbar-tray-open'); } if (isFixed) { classesToAdd.push('toolbar-fixed'); } if (isOriented) { classesToAdd.push('toolbar-oriented'); } if (activeTray) { // These styles are added so the active tab/tray styles are present // immediately instead of "flickering" on as the toolbar initializes. In // instances where a tray is lazy loaded, these styles facilitate the // lazy loaded tray appearing gracefully and without reflow. const styleContent = .toolbar-loading #+ activeTabId + { background-image: linear-gradient(rgba(255, 255, 255, 0.25) 20%, transparent 200%); } .toolbar-loading #+ activeTabId +-tray { display: block; box-shadow: -1px 0 5px 2px rgb(0 0 0 / 33%); border-right: 1px solid #aaa; background-color: #f5f5f5; z-index: 0; } .toolbar-loading.toolbar-vertical.toolbar-tray-open #+ activeTabId +-tray { width: 15rem; height: 100vh; } .toolbar-loading.toolbar-horizontal :not(#+ activeTray +) > .toolbar-lining {opacity: 0}; const style = document.createElement('style'); style.textContent = styleContent; style.setAttribute('data-toolbar-anti-flicker-loading', true); document.querySelector('head').appendChild(style); if (userButtonMinWidth) { const userButtonStyle = document.createElement('style'); userButtonStyle.textContent = #toolbar-item-user {min-width: + userButtonMinWidth +px;} document.querySelector('head').appendChild(userButtonStyle); } } } document.querySelector('html').classList.add(...classesToAdd); })();

image

rfay avatar Sep 19 '23 20:09 rfay

I have seen that before but was unable to reproduce it when I had time. I'll try playing around and see if I can reproduce it.

tyler36 avatar Nov 07 '23 06:11 tyler36

Was playing around with Umami on Drupal 11 today. Wasn't able to replicate the issue.

Going to close this for now. Happy to reopen if we can figure out steps to reprode this or we get more information.

tyler36 avatar Dec 17 '24 02:12 tyler36