OCP David Declerck
OCP David Declerck
Merged in SVN @ 5448.
> I suggest to wrap the commits again. From what I've inspected we need one refactor for integrating 4.x logic (you've spotted that well) nicely. Saw your message a bit...
I tend to be overly "conservative". Indeed this piece of code is barely modified afterwards, so I'll do the refactoring.
Is this okay to merge (@GitMensch) ?
> looks_absolute should use "src", not file_open_name directly (merge issue?) This change is introduced in a later commit (3993). > "apply_file_paths" should get that via argument as well and have...
I made the necessary changes. > > This change is introduced in a later commit (3993). > > good catch - then it is fine to leave as is; if...
> That batch is good to go :-) Merged in SVN ;) I see the next commits deal with translation files. Checking the history, it seems those files are usually...
Alright. > And of course Hope this unfinished sentence did not have any vital info 😅
Quick question: I sometimes see alternative code for GC4 in `#if 0` blocks; I guess I should implement those and drop the other branch, correct ? I'm talking about those:...
> That's quite a bunch - any reason to not merge upstream? Open issues you are aware of or special adjustments needed? No good reason. It may be many commits,...