imap icon indicating copy to clipboard operation
imap copied to clipboard

prepareMessageIds returns only string

Open piernik opened this issue 5 years ago • 5 comments

Function prepareMessageIds is not accepting int as input value. In my case uid is int (it is returned by $mailbox->getStatus(SA_UIDNEXT). Can You add another parser in that function?

private function prepareMessageIds($messageIds): string
    {
        if ($messageIds instanceof MessageIterator) {
            $messageIds = $messageIds->getArrayCopy();
        }

        if (\is_array($messageIds)) {
            $messageIds = \implode(',', $messageIds);
        }
        if (\is_int($messageIds)) {
            $messageIds = $messageIds . '';
        }

        return $messageIds;
    }

piernik avatar Jun 09 '20 11:06 piernik

Why not just passing it as a string?

Slamdunk avatar Jun 09 '20 12:06 Slamdunk

Multiple places - it was only example... My mail server returns uid as number

piernik avatar Jun 09 '20 12:06 piernik

Can you propose a PR please?

Slamdunk avatar Jun 09 '20 12:06 Slamdunk

I'm not github fluent. Code is above

piernik avatar Jun 10 '20 06:06 piernik

Github provides insightful help on the topic: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/overview

Slamdunk avatar Jun 10 '20 09:06 Slamdunk